Fix: Use PureWindowsPath to ensure that Windows paths are properly handled on POSIX - #20
Merged
Conversation
… on POSIX systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Part of: #18
Description
Our Phenix is connected to Windows machine and the users I support have XML files with:
<URL>r02c03\r02c03f07p19-ch01t01.tiff</URL>Note the
\as the path separator.If PyPhenix is used on macOS or linux, then the
\is read as part of the file name and no data is loaded.This PR uses PureWindowsPath from pathlib to parse the relative path and then get the POSIX string.
The raw path was also used in the initial setup, so now that also goes through the image path helper.
With a bit of Claude I also added a minimal regression test that fails on main and passes with this branch.